feat(funnel): report the onboarded activation milestone - #40
Merged
Merged
Conversation
One call in update_profile, right after drumate_update_profile. HERE AND NOT IN mark_complete(). mark_complete only VALIDATES that the mandatory steps are stored — it can succeed and then be followed by a failed update_profile, leaving a user who never got `onboarded = 1` and meets the wizard again on next login. The profile write is the line that actually ends onboarding, so the milestone belongs after it. This is the only timestamp the stage will ever have. drumate.profile.$.onboarded is a boolean and nothing else records when the wizard was finished — which is why the funnel needs a row at all rather than a derived query. Accounts that completed before this ships are backfilled with their signup time and flagged approx=1. Not awaited and never throws, exactly like _pushReferralLive beside it: onboarding completion is the user's flow and an analytics row is a bystander. Idempotent at the database — yp.funnel_milestone is keyed (uid, milestone) — so a user who reruns the wizard keeps the timestamp of their first completion. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One call in update_profile, right after drumate_update_profile.
HERE AND NOT IN mark_complete(). mark_complete only VALIDATES that the mandatory steps are stored — it can succeed and then be followed by a failed update_profile, leaving a user who never got
onboarded = 1and meets the wizard again on next login. The profile write is the line that actually ends onboarding, so the milestone belongs after it.This is the only timestamp the stage will ever have. drumate.profile.$.onboarded is a boolean and nothing else records when the wizard was finished — which is why the funnel needs a row at all rather than a derived query. Accounts that completed before this ships are backfilled with their signup time and flagged approx=1.
Not awaited and never throws, exactly like _pushReferralLive beside it: onboarding completion is the user's flow and an analytics row is a bystander. Idempotent at the database — yp.funnel_milestone is keyed (uid, milestone) — so a user who reruns the wizard keeps the timestamp of their first completion.